Skip to content

Drop superfluous (broken) DSL functions #10457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented May 26, 2025

Contains the following two commits:

  • Drop Checkable#process_check_result() DSL function: Not sure why it's introduced in the first place, maybe for debugging purposes at the early stage of Icinga 2 dev but I failed to see an actual useful use case for it that's worth its maintenance burden. So, this commit dropped it entirely from the DSL language.
  • Drop System#track_parents DSL function: No external user needs to manipulate the actual object dependency graphs. This was maybe introduced for debugging purposes at that time but if someone messes with this in prod - good luck with that. Oh, apart from that it's broken :( and doesn't track parents as its name implies but children.

fixes #10272

@yhabteab yhabteab added this to the 2.15.0 milestone May 26, 2025
@yhabteab yhabteab added area/configuration DSL, parser, compiler, error handling core/quality Improve code, libraries, algorithms, inline docs labels May 26, 2025
@cla-bot cla-bot bot added the cla/signed label May 26, 2025
@yhabteab yhabteab changed the title Drop superfluous (broken) DSL function Drop superfluous (broken) DSL functions May 26, 2025
@yhabteab yhabteab force-pushed the remove-superfluous-dsl-functions branch from ae06649 to e685973 Compare June 2, 2025 13:42
@yhabteab yhabteab requested a review from jschmidt-icinga June 2, 2025 14:23
yhabteab added 2 commits June 3, 2025 17:09
Not sure why it's introduced in the first place, maybe for debugging
purposes at the early stage of Icinga 2 dev but I failed to see an
actual useful use case for it that's worth its maintenance burden. So,
this commit dropped it entirely from the DSL language.
No external user needs to manipulate the actual object dependency
graphs. This was maybe introduced for debugging purposes at that time
but if someone messes with this in prod - good luck with that. Oh, apart
from that it's broken :( and doesn't track parents as its implies but
children.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration DSL, parser, compiler, error handling cla/signed core/quality Improve code, libraries, algorithms, inline docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop DSL function System.track_parents()
1 participant